Skip to content

fix: custom job url after rebrand#6639

Closed
racinmat wants to merge 5 commits intogoogleapis:mainfrom
racinmat:racinsky/fix-custom-job-url
Closed

fix: custom job url after rebrand#6639
racinmat wants to merge 5 commits intogoogleapis:mainfrom
racinmat:racinsky/fix-custom-job-url

Conversation

@racinmat
Copy link
Copy Markdown
Contributor

@racinmat racinmat commented Apr 24, 2026

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Get the necessary approvals
  • Once the last commit on the PR has been approved, add the "ready to pull" label to the Pull Request

Note: do not merge your PR from GitHub. Adding the "ready to pull" label is the final step in the review process.
After approvals, the changes in your PR will be committed to the main branch and this PR will be closed.

Fixes #6638 🦕

@racinmat racinmat requested a review from a team as a code owner April 24, 2026 10:47
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Apr 24, 2026
@matthew29tang matthew29tang added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2026
@matthew29tang
Copy link
Copy Markdown
Contributor

matthew29tang commented Apr 27, 2026

The lint is failing, can you fix it?

@@ -1348,13 +1348,11 @@
         )
         uri = bp._dashboard_uri()
         assert "/agent-platform/" in uri
         assert "/ai/platform/" not in uri
 
-    def test_batch_prediction_dashboard_uri_format(
-        self, get_batch_prediction_job_mock
-    ):
+    def test_batch_prediction_dashboard_uri_format(self, get_batch_prediction_job_mock):
         aiplatform.init(project=_TEST_PROJECT, location=_TEST_LOCATION)
         bp = jobs.BatchPredictionJob(
             batch_prediction_job_name=_TEST_BATCH_PREDICTION_JOB_NAME
         )
         uri = bp._dashboard_uri()
would reformat /tmpfs/src/github/python-aiplatform/tests/unit/aiplatform/test_jobs.py

@matthew29tang matthew29tang self-assigned this Apr 27, 2026
@racinmat
Copy link
Copy Markdown
Contributor Author

racinmat commented Apr 29, 2026

I fixed the formatting, please run the tests now.

@matthew29tang matthew29tang added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2026
@matthew29tang matthew29tang added the ready to pull Ready to be merged into the codebase. label Apr 29, 2026
copybara-service Bot pushed a commit that referenced this pull request Apr 29, 2026
@racinmat @copybara-github
Copybara import of the project:
aabe816 
--
0f3c83e by Matěj Račinský <racinsky.matej@seznam.cz>:

fix: custom job url after rebrand

--
b58531e by Matěj Račinský <racinsky.matej@seznam.cz>:

style: format
COPYBARA_INTEGRATE_REVIEW=#6639 from racinmat:racinsky/fix-custom-job-url a682d8e
PiperOrigin-RevId: 907702997
@matthew29tang
Copy link
Copy Markdown
Contributor

matthew29tang commented Apr 29, 2026

Merged as aabe816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthew29tang matthew29tang matthew29tang approved these changes

Assignees

@matthew29tang matthew29tang

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. ready to pull Ready to be merged into the codebase. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

wrong url for custom training job

3 participants

@racinmat @matthew29tang @yoshi-kokoro